Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish calculated failure rate #582

Merged

Conversation

kostobog
Copy link
Collaborator

@blcham
Fixes #536

…dated or violates requirement.

- use orange for outdated and red for requirement violation
- implemented for fault tree overview table and fault event side bar in fault tree editor
@kostobog kostobog merged commit 02ee0b6 into main Aug 29, 2024
1 check passed
@kostobog kostobog deleted the fix/536-distinguish-fault-trees-violating-reuired-failure-rate branch August 29, 2024 12:05
faultTree?.requiredFailureRate &&
faultTree?.calculatedFailureRate &&
faultTree?.calculatedFailureRate > faultTree?.requiredFailureRate;
const violatedRequirementStatusColor = violatedRequirement ? theme.main.red : theme.main.black;
Copy link
Contributor

@blcham blcham Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kostobog
Not sure but don't we want to use custom style here instead saying red ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blcham
You mean something like theme.requirementViolation.color?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes something like that ...

@kostobog kostobog mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish fault trees which violate required probability
2 participants